feat: add new architecture support in Android #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored MParticleModule and MPRoktModule to extend from new base classes for TurboModules. - Updated build.gradle to enable new architecture and adjust build features. - Introduced new Kotlin files for Rokt module implementation in the new architecture.
thomson-t
force-pushed
the
feat/new-architecture-android
branch
from
e8b0078 to
0ecd509
Compare
jamesnrokt
reviewed
Jul 22, 2025
Contributor
jamesnrokt
left a comment
jamesnrokt
left a comment
There was a problem hiding this comment.
Minor comments as discussed
android/src/newarch/java/com/mparticle/react/rokt/MPRoktModule.kt
Outdated
Show resolved
Hide resolved
android/src/newarch/java/com/mparticle/react/rokt/MPRoktModule.kt
Outdated
Show resolved
Hide resolved
jamesnrokt
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Tested by enabling and disabling
newArchEnabledflag in gradle.propertiesMaster Issue
Closes https://go.mparticle.com/work/REPLACEME